Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the version of the second bandit hook #111

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Update the version of the second bandit hook #111

merged 2 commits into from
Jan 7, 2023

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 9, 2022 •
edited
Loading

🗣 Description

This pull request updates the bandit (everything else) hook to use the latest version of bandit. It also includes some cleanup for the explanatory comments for both bandit hooks.

💭 Motivation and context

This hook was not kept in sync with updates to the bandit (tests tree) hook and is using an older version of bandit. The comments make this configuration consistent with cisagov/skeleton-packer#188.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Nov 9, 2022
@mcdonnnj mcdonnnj self-assigned this Nov 9, 2022
dav3r
dav3r approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj mentioned this pull request Nov 21, 2022
Merged
6 tasks
mcdonnnj added a commit that referenced this pull request Jan 7, 2023
@mcdonnnj
Merge pull request #111 from cisagov/dependabot/github_actions/hashic…
4925eb1 
…orp/setup-terraform-2

Bump hashicorp/setup-terraform from 1 to 2
mcdonnnj and others added 2 commits January 7, 2023 14:59
@mcdonnnj
Update the version of the second bandit hook
62c8394 
The `bandit (everything else)` hook was not updated in sync with the
`bandit (tests tree)` hook and is using an older version of bandit.
@mcdonnnj @dav3r
Correct poor English in comments for the bandit pre-commit hooks
99ee709 
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
@mcdonnnj mcdonnnj force-pushed the bug/update_bandit_in_pre-commit_configuration branch from ad00900 to 99ee709 Compare January 7, 2023 20:00
@mcdonnnj mcdonnnj added kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release test This issue or pull request adds or otherwise modifies test code labels Jan 7, 2023
@mcdonnnj mcdonnnj merged commit 36b39b8 into develop Jan 7, 2023
@mcdonnnj mcdonnnj deleted the bug/update_bandit_in_pre-commit_configuration branch January 7, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release test This issue or pull request adds or otherwise modifies test code
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r